Fix view of VectorOfArray with heterogeneous array sizes #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SciML#453 The issue was that `view(f, :, i)` for a VectorOfArray with heterogeneous inner array sizes returned incorrect results. The problem was that `to_indices` uses `axes`, which is based on the first element's size, causing views of columns with different sizes to have incorrect dimensions. Solution: Added special handling for `view(A, :, i)` where `i` is an Int, to use the actual size of the specific column being viewed rather than relying on `to_indices`. Changes: - Modified Base.view for AbstractVectorOfArray to handle heterogeneous arrays by computing the correct indices based on the actual column size - Added comprehensive tests for views of heterogeneous arrays including: * Testing correct lengths of views * Testing that views match regular indexing * Testing that views can be modified All existing tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ChrisRackauckas
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #453 -
view(f, :, i)for a VectorOfArray with heterogeneous inner array sizes now returns the correct result.Problem
Previously, when viewing a specific column of a VectorOfArray with differently sized inner arrays:
view(VectorOfArray([[1.0], [2.0, 3.0]]), :, 2)returned a 1-element view instead of 2 elementsview(VectorOfArray([[1.0, 2.0], [3.0]]), :, 2)returned a 2-element view with#undefinstead of 1 elementThe root cause was that
to_indicesusesaxes, which is computed based on the first element's size. This doesn't work for heterogeneous arrays where different columns have different sizes.Solution
Added special handling for
view(A, :, i)whereiis an Int to use the actual size of the specific column being viewed rather than relying onto_indices.Changes
Base.viewforAbstractVectorOfArrayto handle heterogeneous arrays correctlyTesting
All existing tests pass, plus new tests specifically for this issue.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]